This repository has been archived by the owner on Sep 6, 2022. It is now read-only.
remove OpenedStream and ClosedStream from Notifiee interface #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now done via the event bus.
|
|
vyzo
approved these changes
May 20, 2022
|
We ahve some tests inside bitswap, but that's it. It looks like elrond may have been using this for some form of connection management, but really the hook isn't all that useful. I'd remove it and figure out a way to fix upstream. |
MarcoPolo
approved these changes
May 20, 2022
dennis-tra
added a commit
to libp2p/punchr
that referenced
this pull request
Jun 14, 2022
Fixes issue #10 Pull request libp2p/go-libp2p-core#250 removed the OpenStream notification. Punchr uses the notification here: https://github.com/dennis-tra/punchr/blob/c4b2fcf93e63ae4a8656864a399638c0c9641372/cmd/client/host.go#L372
dennis-tra
added a commit
to libp2p/punchr
that referenced
this pull request
Jun 14, 2022
Fixes issue #10 Pull request libp2p/go-libp2p-core#250 removed the OpenStream notification. Punchr uses the notification here: https://github.com/dennis-tra/punchr/blob/c4b2fcf93e63ae4a8656864a399638c0c9641372/cmd/client/host.go#L372
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, nobody is using the
OpenedStreamandClosedStreamnotification.This is because they're not really useful: You can get a notification that the swarm opened a new stream, but you can read, write, close or reset the stream without interfering with the application. Therefore you won't even know which libp2p protocol is being negotiated on that stream.